Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1013243002: CpuProfiler: x87. put right address to the stack, so the callee would be able to resolve it into th… (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Jarin, Sven Panne, alph
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: x87. put right address to the stack, so the callee would be able to resolve it into the right deopt_info. 'from' is using for Code object lookup and will be used for inline_id lookup. see https://codereview.chromium.org/1012633002 So we should be able to map it. BUG=chromium:452067 LOG=n Committed: https://crrev.com/549d5dde6a454343fe0edd4b52327724265e0dc2 Cr-Commit-Position: refs/heads/master@{#27251}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments were added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -27 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 2 chunks +50 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-17 17:38:24 UTC) #2
alph
answer the comment and then lgtm https://codereview.chromium.org/1013243002/diff/1/src/x87/lithium-codegen-x87.cc File src/x87/lithium-codegen-x87.cc (right): https://codereview.chromium.org/1013243002/diff/1/src/x87/lithium-codegen-x87.cc#newcode392 src/x87/lithium-codegen-x87.cc:392: if (info()->saves_caller_doubles()) RestoreCallerDoubles(); ...
5 years, 9 months ago (2015-03-17 18:01:58 UTC) #3
loislo
On 2015/03/17 at 18:01:58, alph wrote: > answer the comment and then lgtm > > ...
5 years, 9 months ago (2015-03-17 18:05:18 UTC) #4
Sven Panne
lgtm
5 years, 9 months ago (2015-03-18 08:04:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013243002/20001
5 years, 9 months ago (2015-03-18 08:07:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 08:08:33 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 08:08:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/549d5dde6a454343fe0edd4b52327724265e0dc2
Cr-Commit-Position: refs/heads/master@{#27251}

Powered by Google App Engine
This is Rietveld 408576698