Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1013203002: PlzNavigate: Update the pending navigation params in RenderViewImpl. (Closed)

Created:
5 years, 9 months ago by Avi (use Gerrit)
Modified:
5 years, 9 months ago
Reviewers:
clamy
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Update the pending navigation params in RenderViewImpl. BUG=369661 TEST=none Committed: https://crrev.com/d0ea87fe25a4e769ff2aceea68563fc119b27c14 Cr-Commit-Position: refs/heads/master@{#320929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Avi (use Gerrit)
Camille— Is this what you had in mind with your comment on https://codereview.chromium.org/1002803002/ ?
5 years, 9 months ago (2015-03-17 15:03:43 UTC) #2
clamy
Yes precisely, thanks! Lgtm.
5 years, 9 months ago (2015-03-17 15:05:19 UTC) #3
Avi (use Gerrit)
On 2015/03/17 15:05:19, clamy wrote: > Yes precisely, thanks! Lgtm. I wish all the changes ...
5 years, 9 months ago (2015-03-17 15:08:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013203002/1
5 years, 9 months ago (2015-03-17 15:08:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 16:10:28 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 16:11:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0ea87fe25a4e769ff2aceea68563fc119b27c14
Cr-Commit-Position: refs/heads/master@{#320929}

Powered by Google App Engine
This is Rietveld 408576698