content/renderer/render_frame_impl.cc - Issue 1013203002: PlzNavigate: Update the pending navigation params in RenderViewImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1013203002: PlzNavigate: Update the pending navigation params in RenderViewImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 5e48d1b433da3eaacae660fb6187524c3656571c..52fcd77875d1c05dfa1475edb5570d964c069119 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -3956,7 +3956,8 @@ void RenderFrameImpl::OnCommitNavigation(

GetContentClient()->SetActiveURL(common_params.url);

- // TODO(clamy): reset the pending navigation parameters in RenderView.

+ render_view_->pending_navigation_params_.reset(new NavigationParams(

+ common_params, StartNavigationParams(), commit_params, history_params));

if (!common_params.base_url_for_data_url.is_empty() ||

common_params.url.SchemeIs(url::kDataScheme)) {

« no previous file with comments | « no previous file | content/renderer/render_view_impl.h » ('j') | no next file with comments »