Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: pkg/analyzer/lib/task/general.dart

Issue 1012993002: Rename ContributionPoint and error result (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/task/general.dart
diff --git a/pkg/analyzer/lib/task/general.dart b/pkg/analyzer/lib/task/general.dart
index 3a92c30cc2fdd3e41dd853eb565592c06858a92e..7cf1b97f2d6716e7283b5bc1c41436f10832feca 100644
--- a/pkg/analyzer/lib/task/general.dart
+++ b/pkg/analyzer/lib/task/general.dart
@@ -4,25 +4,10 @@
library analyzer.task.general;
-import 'package:analyzer/src/generated/error.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/task/model.dart';
/**
- * The analysis errors associated with a target.
- *
- * The value combines errors represented by multiple other results.
- */
-// TODO(brianwilkerson) If we want to associate errors with targets smaller than
-// a file, we will need other contribution points to collect them. In which case
-// we might want to rename this and/or document that it applies to files. For
-// that matter, we might also want to have one that applies to Dart files and a
-// different one that applies to HTML files, because the list of errors being
-// combined is likely to be different.
-final ContributionPoint<List<AnalysisError>> ANALYSIS_ERRORS =
- new ContributionPoint<List<AnalysisError>>('ANALYSIS_ERRORS');
-
-/**
* The contents of a single file.
*/
final ResultDescriptor<String> CONTENT =

Powered by Google App Engine
This is Rietveld 408576698