Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1012773005: Improve tracing/logging system used in lib/naclports (Closed)

Created:
5 years, 9 months ago by Sam Clegg
Modified:
5 years, 9 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Improve tracing/logging system used in lib/naclports There are now 5 levels of logging and the -v flag can be specified multiple times to increase the log level. R=binji@chromium.org Committed: https://chromium.googlesource.com/external/naclports/+/3cf83c54fda7ac0f6113a406ea9638b659801626

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -47 lines) Patch
M build_tools/partition.py View 5 chunks +7 lines, -7 lines 0 comments Download
M build_tools/scan_packages.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build_tools/update_mirror.py View 1 chunk +1 line, -1 line 0 comments Download
M lib/naclports/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M lib/naclports/__main__.py View 1 3 chunks +9 lines, -5 lines 1 comment Download
M lib/naclports/binary_package.py View 1 3 chunks +3 lines, -2 lines 0 comments Download
M lib/naclports/package.py View 2 chunks +6 lines, -6 lines 0 comments Download
M lib/naclports/package_index.py View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/naclports/source_package.py View 7 chunks +10 lines, -10 lines 0 comments Download
M lib/naclports/util.py View 5 chunks +28 lines, -11 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Sam Clegg
5 years, 9 months ago (2015-03-16 22:48:37 UTC) #2
binji
lgtm https://codereview.chromium.org/1012773005/diff/20001/lib/naclports/__main__.py File lib/naclports/__main__.py (right): https://codereview.chromium.org/1012773005/diff/20001/lib/naclports/__main__.py#newcode262 lib/naclports/__main__.py:262: util.SetLogLevel(util.LOG_MESSAGE + args.verbosity) LOG_MESSAGE makes it sound like ...
5 years, 9 months ago (2015-03-17 19:28:12 UTC) #3
Sam Clegg
5 years, 9 months ago (2015-03-17 20:16:35 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3cf83c54fda7ac0f6113a406ea9638b659801626.

Powered by Google App Engine
This is Rietveld 408576698