build_tools/scan_packages.py - Issue 1012773005: Improve tracing/logging system used in lib/naclports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_tools/scan_packages.py

Issue 1012773005: Improve tracing/logging system used in lib/naclports (Closed) Base URL: https://chromium.googlesource.com/external/naclports.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build_tools/scan_packages.py

diff --git a/build_tools/scan_packages.py b/build_tools/scan_packages.py

index 82a91bfb479e94db20487f223578adcf988f88f3..93aca149fc8aaed21770c0fdf1e2496b174069b9 100755

--- a/build_tools/scan_packages.py

+++ b/build_tools/scan_packages.py

@@ -26,7 +26,7 @@ import naclports

import naclports.package

import naclports.package_index

-from naclports import Log, Trace

+from naclports.util import Log, LogVerbose

def FormatSize(num_bytes):

@@ -141,7 +141,7 @@ def main(args):

else:

Log("Searching for packages at: %s" % gs_url)

cmd = ['gsutil', 'ls', '-le', gs_url]

- Trace("Running: %s" % str(cmd))

+ LogVerbose("Running: %s" % str(cmd))

try:

listing = subprocess.check_output(cmd)

except subprocess.CalledProcessError as e:

« no previous file with comments | « build_tools/partition.py ('k') | build_tools/update_mirror.py » ('j') | lib/naclports/__main__.py » ('J')