Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1012743002: CpuProfiler: x64. put right address to the stack, so the callee would be able... (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
alph, Sven Panne, Jarin, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: x64. put right address to the stack, so the callee would be able to resolve it into the right deopt_info. 'from' is using for Code object lookup and will be used for inline_id lookup. see https://codereview.chromium.org/1012633002 So we should be able to map it. BUG=chromium:452067 LOG=n Committed: https://crrev.com/cc3337c1c2d0cff54fd18afc495ed1e102e6da34 Cr-Commit-Position: refs/heads/master@{#27253}

Patch Set 1 #

Patch Set 2 : redesined #

Patch Set 3 : stack layout comments were added #

Patch Set 4 : minor changes in comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -20 lines) Patch
M src/x64/lithium-codegen-x64.cc View 1 2 3 3 chunks +53 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-16 14:55:07 UTC) #2
Sven Panne
Adding "Mr. Deopt"... ;-)
5 years, 9 months ago (2015-03-16 14:59:05 UTC) #4
alph
lgtm. please mention in the description that this is for x64
5 years, 9 months ago (2015-03-16 15:12:38 UTC) #5
alph
still lgtm
5 years, 9 months ago (2015-03-17 17:54:48 UTC) #6
Sven Panne
LGTM. What about ARM/ARM64 ports? For future CLs, please do all ports in a single ...
5 years, 9 months ago (2015-03-18 08:03:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012743002/60001
5 years, 9 months ago (2015-03-18 08:06:57 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-18 08:31:32 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 08:31:45 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cc3337c1c2d0cff54fd18afc495ed1e102e6da34
Cr-Commit-Position: refs/heads/master@{#27253}

Powered by Google App Engine
This is Rietveld 408576698