Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1012723002: Use C locale for numerics when emitting shaders. (Closed)

Created:
5 years, 9 months ago by bsalomon
Modified:
5 years, 9 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use C locale for numerics when emitting shaders. BUG=skia:3330 Committed: https://skia.googlesource.com/skia/+/3318ee7d5e9ac352bcf8ab6af5724d9a94e6e198

Patch Set 1 #

Patch Set 2 : xlocale.h? #

Patch Set 3 : xlocal on mac #

Patch Set 4 : update for android #

Patch Set 5 : rewrite #

Patch Set 6 : enable workaround #

Patch Set 7 : fix unused param warning and assert spelling #

Patch Set 8 : actually fix spelling #

Patch Set 9 : fix mac includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M include/gpu/GrTypesPriv.h View 1 2 3 4 5 6 7 8 1 chunk +47 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
bsalomon
5 years, 9 months ago (2015-03-16 14:32:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012723002/1
5 years, 9 months ago (2015-03-16 14:32:50 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-16 14:32:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/2487)
5 years, 9 months ago (2015-03-16 14:35:22 UTC) #7
joshualitt
On 2015/03/16 14:35:22, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-16 14:46:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012723002/20001
5 years, 9 months ago (2015-03-16 15:49:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/2493)
5 years, 9 months ago (2015-03-16 15:53:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012723002/160001
5 years, 9 months ago (2015-03-16 18:39:27 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 18:56:33 UTC) #17
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/3318ee7d5e9ac352bcf8ab6af5724d9a94e6e198

Powered by Google App Engine
This is Rietveld 408576698