Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1012713003: IDL: Improve CG for attributes with [CachedAttribute] (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Improve CG for attributes with [CachedAttribute] Avoid converting the C++ value to a V8 value twice (once for the call to V8HiddenValue::setHiddenValue() and once for the function return value) by storing the converted value in a local and using that in both places. The similar case attribute.is_keep_alive_for_gc already worked this way, but with a different variable name ('wrapper' instead of 'v8Value'). The only significant CG change is that the Vector<String> returned by Navigator::languages() is now converted only once, and that the same resulting JavaScript array object is returned on the first access as on subsequent accesses. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -50 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 10 chunks +35 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-16 14:59:22 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-16 23:46:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012713003/1
5 years, 9 months ago (2015-03-17 05:56:47 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 06:00:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191980

Powered by Google App Engine
This is Rietveld 408576698