Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

Issue 1012713003: IDL: Improve CG for attributes with [CachedAttribute] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp
index 0fb5af985a52ef62b7fc65e12369cf21038dc404..3b72b5b219044707091fec6e70a910083331f6ae 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp
@@ -114,10 +114,10 @@ static void initializedByEventConstructorReadonlyUint8ArrayAttributeAttributeGet
RefPtr<DOMUint8Array> cppValue(impl->initializedByEventConstructorReadonlyUint8ArrayAttribute());
if (cppValue && DOMDataStore::setReturnValue(info.GetReturnValue(), cppValue.get()))
return;
- v8::Local<v8::Value> wrapper = toV8(cppValue.get(), holder, info.GetIsolate());
- if (!wrapper.IsEmpty()) {
- V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyUint8ArrayAttribute"), wrapper);
- v8SetReturnValue(info, wrapper);
+ v8::Local<v8::Value> v8Value(toV8(cppValue.get(), holder, info.GetIsolate()));
+ if (!v8Value.IsEmpty()) {
+ V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyUint8ArrayAttribute"), v8Value);
+ v8SetReturnValue(info, v8Value);
}
}
@@ -135,10 +135,10 @@ static void initializedByEventConstructorReadonlyTestInterfaceEmptyAttributeAttr
RefPtr<TestInterfaceEmpty> cppValue(impl->initializedByEventConstructorReadonlyTestInterfaceEmptyAttribute());
if (cppValue && DOMDataStore::setReturnValue(info.GetReturnValue(), cppValue.get()))
return;
- v8::Local<v8::Value> wrapper = toV8(cppValue.get(), holder, info.GetIsolate());
- if (!wrapper.IsEmpty()) {
- V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyTestInterfaceEmptyAttribute"), wrapper);
- v8SetReturnValue(info, wrapper);
+ v8::Local<v8::Value> v8Value(toV8(cppValue.get(), holder, info.GetIsolate()));
+ if (!v8Value.IsEmpty()) {
+ V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyTestInterfaceEmptyAttribute"), v8Value);
+ v8SetReturnValue(info, v8Value);
}
}
@@ -170,10 +170,10 @@ static void initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttri
RefPtr<TestInterfaceEmpty> cppValue(impl->initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute());
if (cppValue && DOMDataStore::setReturnValue(info.GetReturnValue(), cppValue.get()))
return;
- v8::Local<v8::Value> wrapper = toV8(cppValue.get(), holder, info.GetIsolate());
- if (!wrapper.IsEmpty()) {
- V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute"), wrapper);
- v8SetReturnValue(info, wrapper);
+ v8::Local<v8::Value> v8Value(toV8(cppValue.get(), holder, info.GetIsolate()));
+ if (!v8Value.IsEmpty()) {
+ V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute"), v8Value);
+ v8SetReturnValue(info, v8Value);
}
}
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698