Issue 1012683003: Remove some dead code, fix some includes and whitespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1012683003: Remove some dead code, fix some includes and whitespace. (Closed)

Created:
5 years, 9 months ago by erikwright (departed)

Modified:
5 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, grt (UTC plus 2), robertshield, Sigurður Ásgeirsson

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove some dead code, fix some includes and whitespace. BUG= Committed: https://crrev.com/dfe2976d270dba46671daa6ca543d515f37a36a9 Cr-Commit-Position: refs/heads/master@{#320732}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -50 lines)			Patch
	M	chrome/common/logging_chrome.h	View		2 chunks	+2 lines, -17 lines	0 comments	Download
	M	chrome/common/logging_chrome.cc	View		3 chunks	+3 lines, -33 lines	0 comments	Download

Total messages: 7 (2 generated)

erikwright (departed)

jochen: PTAL. Just removing some functions that are never invoked.

5 years, 9 months ago (2015-03-16 14:17:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012683003/1

5 years, 9 months ago (2015-03-16 15:35:19 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-16 16:07:37 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dfe2976d270dba46671daa6ca543d515f37a36a9
Cr-Commit-Position: refs/heads/master@{#320732}