Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: chrome/common/logging_chrome.h

Issue 1012683003: Remove some dead code, fix some includes and whitespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/logging_chrome.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome.h
diff --git a/chrome/common/logging_chrome.h b/chrome/common/logging_chrome.h
index 07a97df1255b1cab01787b98ba85116bf4d61ddb..1e2f29ce3695bd2153d15c1b9e01e33c00598e6b 100644
--- a/chrome/common/logging_chrome.h
+++ b/chrome/common/logging_chrome.h
@@ -5,9 +5,6 @@
#ifndef CHROME_COMMON_LOGGING_CHROME_H__
#define CHROME_COMMON_LOGGING_CHROME_H__
-#include <string>
-#include <vector>
-
#include "base/logging.h"
#include "base/time/time.h"
@@ -51,22 +48,10 @@ void CleanupChromeLogging();
// Returns the fully-qualified name of the log file.
base::FilePath GetLogFileName();
-// Returns true when error/assertion dialogs are to be shown,
-// false otherwise.
+// Returns true when error/assertion dialogs are not to be shown, false
+// otherwise.
bool DialogsAreSuppressed();
-typedef std::vector<std::wstring> AssertionList;
-
-// Gets the list of fatal assertions in the current log file, and
-// returns the number of fatal assertions. (If you don't care
-// about the actual list of assertions, you can pass in NULL.)
-// NOTE: Since this reads the log file to determine the assertions,
-// this operation is O(n) over the length of the log.
-// NOTE: This can fail if the file is locked for writing. However,
-// this is unlikely as this function is most useful after
-// the program writing the log has terminated.
-size_t GetFatalAssertions(AssertionList* assertions);
-
// Inserts timestamp before file extension in the format
// "_yymmdd-hhmmss".
base::FilePath GenerateTimestampedName(const base::FilePath& base_path,
« no previous file with comments | « no previous file | chrome/common/logging_chrome.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698