Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1012603002: Remove unreferenced methods from LayoutBlockFlow.h (Closed)

Created:
5 years, 9 months ago by Sunil Ratnu
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unreferenced methods from LayoutBlockFlow.h Some of the methods in LayoutBlockFlow.h are not referenced anywhere in the code. Hence, removing them. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/layout/LayoutBlockFlow.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sunil Ratnu
Please review this.
5 years, 9 months ago (2015-03-16 06:07:46 UTC) #2
rwlbuis
On 2015/03/16 06:07:46, Sunil Ratnu wrote: > Please review this. Looks ok to me. But ...
5 years, 9 months ago (2015-03-16 14:26:03 UTC) #3
dsinclair
On 2015/03/16 at 14:26:03, rob.buis wrote: > On 2015/03/16 06:07:46, Sunil Ratnu wrote: > > ...
5 years, 9 months ago (2015-03-16 14:48:47 UTC) #4
Julien - ping for review
lgtm. I was going to say to keep some of them but it has been ...
5 years, 9 months ago (2015-03-16 15:04:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012603002/1
5 years, 9 months ago (2015-03-16 15:04:41 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 15:33:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191925

Powered by Google App Engine
This is Rietveld 408576698