Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1012573003: aacc + bbdd (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

aacc + bbdd SkMatrix::mapPts() using aacc/bbdd was always worse than using badc(): - On Intel, it was faster than exisiting swizzle, but badc() is 10% faster still (one pshufd instead of two). - On ARM, existing swizzle < badc() < aacc()+bbdd(), even though aacc() then bbdd() is really a single vtrn instruction. I will revert SkMatrix.cpp before submitting. Just thought you might like to look. Will think more and try to gear up Instruments on ARM. BUG=skia: Committed: https://skia.googlesource.com/skia/+/470fa6f74b8ed08d85af463d5b3ef6f19ed6522a

Patch Set 1 #

Patch Set 2 : revert SkMatrix.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/core/Sk4x.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/opts/Sk4x_neon.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/opts/Sk4x_none.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/opts/Sk4x_sse.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/Sk4xTest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mtklein_C
5 years, 9 months ago (2015-03-24 01:16:43 UTC) #2
reed1
lgtm
5 years, 9 months ago (2015-03-24 12:29:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012573003/20001
5 years, 9 months ago (2015-03-24 13:11:32 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 13:16:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/470fa6f74b8ed08d85af463d5b3ef6f19ed6522a

Powered by Google App Engine
This is Rietveld 408576698