Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1012573002: Remove rtcp_interval from cast_config (Closed)

Created:
5 years, 9 months ago by zhuoyu.qian
Modified:
5 years, 9 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove rtcp_interval from cast_config As the TODO in cast_config.h bu miu@, remove rtcp_interval, since it is always be kDefaultRtcpIntervalMs. BUG= R=miu@chromium.org Committed: https://crrev.com/870abc95c02e4ac0ae3f14ed4d4178be4ec2f98e Cr-Commit-Position: refs/heads/master@{#321523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -50 lines) Patch
M media/cast/cast_config.h View 3 chunks +0 lines, -8 lines 0 comments Download
M media/cast/cast_config.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M media/cast/receiver/frame_receiver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/cast/receiver/frame_receiver.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M media/cast/sender/audio_sender.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/sender/frame_sender.h View 2 chunks +0 lines, -3 lines 0 comments Download
M media/cast/sender/frame_sender.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M media/cast/sender/video_sender.cc View 1 chunk +15 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
zhuoyu.qian
Hi miu, PTAL, Thank you!
5 years, 9 months ago (2015-03-16 03:31:18 UTC) #1
miu
lgtm Thanks for the clean-up work here! :)
5 years, 9 months ago (2015-03-20 04:48:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012573002/1
5 years, 9 months ago (2015-03-20 04:55:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 06:01:56 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 06:03:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/870abc95c02e4ac0ae3f14ed4d4178be4ec2f98e
Cr-Commit-Position: refs/heads/master@{#321523}

Powered by Google App Engine
This is Rietveld 408576698