Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: media/cast/cast_config.h

Issue 1012573002: Remove rtcp_interval from cast_config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/cast/cast_config.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_CAST_CAST_CONFIG_H_ 5 #ifndef MEDIA_CAST_CAST_CONFIG_H_
6 #define MEDIA_CAST_CAST_CONFIG_H_ 6 #define MEDIA_CAST_CAST_CONFIG_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 17 matching lines...) Expand all
28 struct AudioSenderConfig { 28 struct AudioSenderConfig {
29 AudioSenderConfig(); 29 AudioSenderConfig();
30 ~AudioSenderConfig(); 30 ~AudioSenderConfig();
31 31
32 // Identifier referring to the sender, used by the receiver. 32 // Identifier referring to the sender, used by the receiver.
33 uint32 ssrc; 33 uint32 ssrc;
34 34
35 // The receiver's SSRC identifier. 35 // The receiver's SSRC identifier.
36 uint32 receiver_ssrc; 36 uint32 receiver_ssrc;
37 37
38 int rtcp_interval;
39
40 // The total amount of time between a frame's capture/recording on the sender 38 // The total amount of time between a frame's capture/recording on the sender
41 // and its playback on the receiver (i.e., shown to a user). This should be 39 // and its playback on the receiver (i.e., shown to a user). This should be
42 // set to a value large enough to give the system sufficient time to encode, 40 // set to a value large enough to give the system sufficient time to encode,
43 // transmit/retransmit, receive, decode, and render; given its run-time 41 // transmit/retransmit, receive, decode, and render; given its run-time
44 // environment (sender/receiver hardware performance, network conditions, 42 // environment (sender/receiver hardware performance, network conditions,
45 // etc.). 43 // etc.).
46 base::TimeDelta min_playout_delay; 44 base::TimeDelta min_playout_delay;
47 base::TimeDelta max_playout_delay; 45 base::TimeDelta max_playout_delay;
48 46
49 // RTP payload type enum: Specifies the type/encoding of frame data. 47 // RTP payload type enum: Specifies the type/encoding of frame data.
(...skipping 15 matching lines...) Expand all
65 struct VideoSenderConfig { 63 struct VideoSenderConfig {
66 VideoSenderConfig(); 64 VideoSenderConfig();
67 ~VideoSenderConfig(); 65 ~VideoSenderConfig();
68 66
69 // Identifier referring to the sender, used by the receiver. 67 // Identifier referring to the sender, used by the receiver.
70 uint32 ssrc; 68 uint32 ssrc;
71 69
72 // The receiver's SSRC identifier. 70 // The receiver's SSRC identifier.
73 uint32 receiver_ssrc; 71 uint32 receiver_ssrc;
74 72
75 int rtcp_interval;
76
77 // The total amount of time between a frame's capture/recording on the sender 73 // The total amount of time between a frame's capture/recording on the sender
78 // and its playback on the receiver (i.e., shown to a user). This should be 74 // and its playback on the receiver (i.e., shown to a user). This should be
79 // set to a value large enough to give the system sufficient time to encode, 75 // set to a value large enough to give the system sufficient time to encode,
80 // transmit/retransmit, receive, decode, and render; given its run-time 76 // transmit/retransmit, receive, decode, and render; given its run-time
81 // environment (sender/receiver hardware performance, network conditions, 77 // environment (sender/receiver hardware performance, network conditions,
82 // etc.). 78 // etc.).
83 base::TimeDelta min_playout_delay; 79 base::TimeDelta min_playout_delay;
84 base::TimeDelta max_playout_delay; 80 base::TimeDelta max_playout_delay;
85 81
86 // RTP payload type enum: Specifies the type/encoding of frame data. 82 // RTP payload type enum: Specifies the type/encoding of frame data.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 struct FrameReceiverConfig { 118 struct FrameReceiverConfig {
123 FrameReceiverConfig(); 119 FrameReceiverConfig();
124 ~FrameReceiverConfig(); 120 ~FrameReceiverConfig();
125 121
126 // The receiver's SSRC identifier. 122 // The receiver's SSRC identifier.
127 uint32 receiver_ssrc; 123 uint32 receiver_ssrc;
128 124
129 // The sender's SSRC identifier. 125 // The sender's SSRC identifier.
130 uint32 sender_ssrc; 126 uint32 sender_ssrc;
131 127
132 // Mean interval (in milliseconds) between RTCP reports.
133 // TODO(miu): Remove this since it's never not kDefaultRtcpIntervalMs.
134 int rtcp_interval;
135
136 // The total amount of time between a frame's capture/recording on the sender 128 // The total amount of time between a frame's capture/recording on the sender
137 // and its playback on the receiver (i.e., shown to a user). This is fixed as 129 // and its playback on the receiver (i.e., shown to a user). This is fixed as
138 // a value large enough to give the system sufficient time to encode, 130 // a value large enough to give the system sufficient time to encode,
139 // transmit/retransmit, receive, decode, and render; given its run-time 131 // transmit/retransmit, receive, decode, and render; given its run-time
140 // environment (sender/receiver hardware performance, network conditions, 132 // environment (sender/receiver hardware performance, network conditions,
141 // etc.). 133 // etc.).
142 int rtp_max_delay_ms; // TODO(miu): Change to TimeDelta target_playout_delay. 134 int rtp_max_delay_ms; // TODO(miu): Change to TimeDelta target_playout_delay.
143 135
144 // RTP payload type enum: Specifies the type/encoding of frame data. 136 // RTP payload type enum: Specifies the type/encoding of frame data.
145 int rtp_payload_type; 137 int rtp_payload_type;
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 typedef base::Callback<void(scoped_ptr<base::SharedMemory>)> 181 typedef base::Callback<void(scoped_ptr<base::SharedMemory>)>
190 ReceiveVideoEncodeMemoryCallback; 182 ReceiveVideoEncodeMemoryCallback;
191 typedef base::Callback<void(size_t size, 183 typedef base::Callback<void(size_t size,
192 const ReceiveVideoEncodeMemoryCallback&)> 184 const ReceiveVideoEncodeMemoryCallback&)>
193 CreateVideoEncodeMemoryCallback; 185 CreateVideoEncodeMemoryCallback;
194 186
195 } // namespace cast 187 } // namespace cast
196 } // namespace media 188 } // namespace media
197 189
198 #endif // MEDIA_CAST_CAST_CONFIG_H_ 190 #endif // MEDIA_CAST_CAST_CONFIG_H_
OLDNEW
« no previous file with comments | « no previous file | media/cast/cast_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698