Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1012473002: Remove WebPlugin::updateFocus(bool). (Closed)

Created:
5 years, 9 months ago by jbroman
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel, Rick Byers
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M Source/web/tests/FakeWebPlugin.h View 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebPlugin.h View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbroman
+fsamuel because he left the FIXME +rbyers for public/OWNERS
5 years, 9 months ago (2015-03-14 19:29:56 UTC) #2
Fady Samuel
Thanks for the cleanup! lgtm.
5 years, 9 months ago (2015-03-14 19:34:45 UTC) #3
Rick Byers
LGTM
5 years, 9 months ago (2015-03-16 19:58:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012473002/1
5 years, 9 months ago (2015-03-16 20:02:07 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 21:37:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191953

Powered by Google App Engine
This is Rietveld 408576698