Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 1009763002: Remove override of updateFocus(bool) in TestPlugin. (Closed)

Created:
5 years, 9 months ago by jbroman
Modified:
5 years, 9 months ago
Reviewers:
tkent, Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove override of updateFocus(bool) in TestPlugin. This is a prerequisite for the Blink-side CL: https://codereview.chromium.org/1012473002/ R=fsamuel@chromium.org Committed: https://crrev.com/3060bea5ab0933a660a9527be849ba89f4ac9403 Cr-Commit-Position: refs/heads/master@{#320693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/shell/renderer/test_runner/test_plugin.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
jbroman
if this LGTY, will send to an owner for review
5 years, 9 months ago (2015-03-14 18:56:30 UTC) #1
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-14 19:22:07 UTC) #2
jbroman
+tkent for content/shell/renderer/test_runner/OWNERS
5 years, 9 months ago (2015-03-14 19:28:48 UTC) #4
tkent
lgtm
5 years, 9 months ago (2015-03-16 00:33:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009763002/1
5 years, 9 months ago (2015-03-16 00:33:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 01:06:23 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 01:06:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3060bea5ab0933a660a9527be849ba89f4ac9403
Cr-Commit-Position: refs/heads/master@{#320693}

Powered by Google App Engine
This is Rietveld 408576698