Issue 101243003: Remove getCurrentDirectoryURL and getCurrentDirPath from directory_model.js

Issue 101243003: Remove getCurrentDirectoryURL and getCurrentDirPath from directory_model.js (Closed)

Created:
6 years, 12 months ago by mtomasz

Modified:
6 years, 11 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove getCurrentDirectoryURL and getCurrentDirPath from directory_model.js. This CL removes two methods which rely on URL and full paths, what is deprecated. TEST=Tested manually. BUG=328252 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243077

Patch Set 1 #

Total comments: 1

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -56 lines)			Patch
M	chrome/browser/resources/file_manager/foreground/js/directory_model.js	View	2 chunks	+2 lines, -23 lines	1 comment	Download
M	chrome/browser/resources/file_manager/foreground/js/directory_tree.js	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/file_manager.js	View	10 chunks	+23 lines, -30 lines	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/ui/navigation_list.js	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hirono

lgtm! https://codereview.chromium.org/101243003/diff/1/chrome/browser/resources/file_manager/foreground/js/directory_model.js File chrome/browser/resources/file_manager/foreground/js/directory_model.js (left): https://codereview.chromium.org/101243003/diff/1/chrome/browser/resources/file_manager/foreground/js/directory_model.js#oldcode196 chrome/browser/resources/file_manager/foreground/js/directory_model.js:196: * TODO(hirono): Remove the method. Thanks!

6 years, 12 months ago (2013-12-27 07:16:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/101243003/1

6 years, 11 months ago (2014-01-06 05:22:40 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241779

6 years, 11 months ago (2014-01-06 07:01:35 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/101243003/1

6 years, 11 months ago (2014-01-06 08:42:07 UTC) #5

Message was sent while issue was closed.

Change committed as 243077

Expand Messages | Collapse Messages