Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: chrome/browser/resources/file_manager/foreground/js/ui/navigation_list.js

Issue 101243003: Remove getCurrentDirectoryURL and getCurrentDirPath from directory_model.js (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/foreground/js/ui/navigation_list.js
diff --git a/chrome/browser/resources/file_manager/foreground/js/ui/navigation_list.js b/chrome/browser/resources/file_manager/foreground/js/ui/navigation_list.js
index f471aa6c0de10807205e5da5b3e662da32d1cdb7..330033425147d460d3985dc8b5398cbba2aa4884 100644
--- a/chrome/browser/resources/file_manager/foreground/js/ui/navigation_list.js
+++ b/chrome/browser/resources/file_manager/foreground/js/ui/navigation_list.js
@@ -217,8 +217,11 @@ NavigationList.prototype.renderRoot_ = function(modelItem) {
item.setModelItem(modelItem, volumeInfo && volumeInfo.deviceType);
var handleClick = function() {
+ // TODO(mtomasz, yoshiki): Do not use fullPath here, but Entry.
if (item.selected &&
- modelItem.path !== this.directoryModel_.getCurrentDirPath()) {
+ (!this.directoryModel_.getCurrentDirEntry() ||
+ modelItem.path !==
+ this.directoryModel_.getCurrentDirEntry().fullPath)) {
metrics.recordUserAction('FolderShortcut.Navigate');
this.changeDirectory_(modelItem);
}

Powered by Google App Engine
This is Rietveld 408576698