Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1012263002: Enable download_protection_service_unittest.cc on ChromeOS (Closed)

Created:
5 years, 9 months ago by mattm
Modified:
5 years, 9 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable download_protection_service_unittest.cc on ChromeOS Enabling the tests was missed in https://codereview.chromium.org/10970023. BUG=127046 Committed: https://crrev.com/4af792696095afe6ebc8645a6ae5be9ce7ceb342 Cr-Commit-Position: refs/heads/master@{#321843}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mattm
5 years, 9 months ago (2015-03-17 22:02:26 UTC) #2
mattm
ping
5 years, 9 months ago (2015-03-23 01:32:15 UTC) #3
Jay Civelli
lgtm
5 years, 9 months ago (2015-03-23 15:47:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012263002/20001
5 years, 9 months ago (2015-03-23 19:41:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 20:54:58 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 20:55:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4af792696095afe6ebc8645a6ae5be9ce7ceb342
Cr-Commit-Position: refs/heads/master@{#321843}

Powered by Google App Engine
This is Rietveld 408576698