Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 10970023: Enable safe browsing download check on ChromeOS (Closed)

Created:
8 years, 3 months ago by Greg Spencer (Chromium)
Modified:
8 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable safe browsing download check on ChromeOS For some reason this was disabled on ChromeOS, and we want to enable it (even though the files might actually not be dangerous on ChromeOS). BUG=chromium:127046 TEST=ran on device, tested against safe download testing site. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_service.cc View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Greg Spencer (Chromium)
Matt, can you please review this change?
8 years, 3 months ago (2012-09-20 21:31:40 UTC) #1
mattm
lgtm If you're curious, I did a little digging.. still not sure why the download ...
8 years, 3 months ago (2012-09-21 00:07:37 UTC) #2
Greg Spencer (Chromium)
On 2012/09/21 00:07:37, mattm wrote: > lgtm > > If you're curious, I did a ...
8 years, 3 months ago (2012-09-21 00:11:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10970023/1
8 years, 3 months ago (2012-09-21 00:11:51 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 03:36:10 UTC) #5
Change committed as 157911

Powered by Google App Engine
This is Rietveld 408576698