Add flag to disable full PAN storage.

chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc

Index: chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc b/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc
index abd616f0cb3be6b12478acfb72beb9bfae2360c8..6543680c8598c04eca4c637bedd1d0f222dec6c1 100644
--- a/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc
+++ b/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc
@@ -90,6 +90,10 @@ void CardUnmaskPromptControllerImpl::OnUnmaskResponse(
     const base::string16& exp_month,
     const base::string16& exp_year,
     bool should_store_pan) {
+#if defined(OS_LINUX)

[please use gerrit instead, 2015/03/17 20:30:45]

I've seen code that checks for OS_LINUX && !OS_CHROMEOS. For example:

https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/views_del...

I think OS_LINUX is true on OS_CHROMEOS, so your change is also effective on
ChromeOS.

[Evan Stade, 2015/03/17 22:24:34]

good point. I've changed tactics though. I added a new build-time flag which
defaults one way on Linux and the other way elsewhere. This allows us more
flexibility to make changes (doesn't require a code change).

+  DCHECK(!should_store_pan);
+#endif
+
   card_unmask_view_->DisableAndWaitForVerification();
 
   DCHECK(!cvc.empty());
@@ -142,8 +146,6 @@ bool CardUnmaskPromptControllerImpl::ShouldRequestExpirationDate() const {
 }
 
 bool CardUnmaskPromptControllerImpl::GetStoreLocallyStartState() const {
-  // TODO(estade): Don't even offer to save on Linux? Offer to save but
-  // default to false?
   PrefService* prefs =
       user_prefs::UserPrefs::Get(web_contents_->GetBrowserContext());
   return prefs->GetBoolean(prefs::kAutofillWalletImportStorageCheckboxState);