Add flag to disable full PAN storage.

chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.h"
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 72 matching lines @@
 void CardUnmaskPromptControllerImpl::OnUnmaskDialogClosed() {
   card_unmask_view_ = nullptr;
   delegate_->OnUnmaskPromptClosed();
 }
 
 void CardUnmaskPromptControllerImpl::OnUnmaskResponse(
     const base::string16& cvc,
     const base::string16& exp_month,
     const base::string16& exp_year,
     bool should_store_pan) {
+#if defined(OS_LINUX)

[please use gerrit instead, 2015/03/17 20:30:45]

I've seen code that checks for OS_LINUX && !OS_CHROMEOS. For example:

https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/views_del...

I think OS_LINUX is true on OS_CHROMEOS, so your change is also effective on
ChromeOS.

[Evan Stade, 2015/03/17 22:24:34]

good point. I've changed tactics though. I added a new build-time flag which
defaults one way on Linux and the other way elsewhere. This allows us more
flexibility to make changes (doesn't require a code change).

+  DCHECK(!should_store_pan);
+#endif
+
   card_unmask_view_->DisableAndWaitForVerification();
 
   DCHECK(!cvc.empty());
   pending_response_.cvc = cvc;
   if (ShouldRequestExpirationDate()) {
     pending_response_.exp_month = exp_month;
     pending_response_.exp_year = exp_year;
   }
   pending_response_.should_store_pan = should_store_pan;
   // Remember the last choice the user made (on this device).
@@ skipping 32 matching lines @@
 int CardUnmaskPromptControllerImpl::GetCvcImageRid() const {
   return card_.type() == kAmericanExpressCard ? IDR_CREDIT_CARD_CVC_HINT_AMEX
                                               : IDR_CREDIT_CARD_CVC_HINT;
 }
 
 bool CardUnmaskPromptControllerImpl::ShouldRequestExpirationDate() const {
   return card_.GetServerStatus() == CreditCard::EXPIRED;
 }
 
 bool CardUnmaskPromptControllerImpl::GetStoreLocallyStartState() const {
-  // TODO(estade): Don't even offer to save on Linux? Offer to save but
-  // default to false?
   PrefService* prefs =
       user_prefs::UserPrefs::Get(web_contents_->GetBrowserContext());
   return prefs->GetBoolean(prefs::kAutofillWalletImportStorageCheckboxState);
 }
 
 bool CardUnmaskPromptControllerImpl::InputCvcIsValid(
     const base::string16& input_text) const {
   base::string16 trimmed_text;
   base::TrimWhitespace(input_text, base::TRIM_ALL, &trimmed_text);
   size_t input_size = card_.type() == kAmericanExpressCard ? 4 : 3;
@@ skipping 43 matching lines @@
 }
 
 void CardUnmaskPromptControllerImpl::OnDidLoadRiskFingerprint(
     const std::string& risk_data) {
   pending_response_.risk_data = risk_data;
   if (!pending_response_.cvc.empty())
     delegate_->OnUnmaskResponse(pending_response_);
 }
 
 }  // namespace autofill