Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 101203010: Add 64-bit support to browser blacklisting (Closed)

Created:
6 years, 11 months ago by csharp
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add 64-bit support to browser blacklisting BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249755

Patch Set 1 #

Total comments: 15

Patch Set 2 : Responding to comments #

Total comments: 3

Patch Set 3 : Rebase #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : Rebase #

Patch Set 6 : Responding to comments #

Total comments: 6

Patch Set 7 : Rebase #

Patch Set 8 : responding to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -19 lines) Patch
M chrome_elf/blacklist/blacklist.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M chrome_elf/blacklist/blacklist.cc View 1 2 3 4 5 6 7 4 chunks +43 lines, -15 lines 0 comments Download
M chrome_elf/blacklist/blacklist_interceptions.h View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M chrome_elf/blacklist/blacklist_interceptions.cc View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M chrome_elf/blacklist/test/blacklist_test.cc View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M sandbox/win/src/service_resolver_64.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
csharp
I tested locally and everything seemed to be working as expected. https://codereview.chromium.org/101203010/diff/1/chrome_elf/blacklist/blacklist_interceptions.cc File chrome_elf/blacklist/blacklist_interceptions.cc (right): ...
6 years, 11 months ago (2014-01-07 18:02:40 UTC) #1
robertshield
Looks great. +rvargas for the change in the sandbox code (I think it might not ...
6 years, 11 months ago (2014-01-07 18:30:46 UTC) #2
csharp
https://codereview.chromium.org/101203010/diff/1/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/101203010/diff/1/chrome_elf/blacklist/blacklist.cc#newcode225 chrome_elf/blacklist/blacklist.cc:225: #if defined(_WIN64) On 2014/01/07 18:30:47, robertshield wrote: > This ...
6 years, 11 months ago (2014-01-07 20:43:07 UTC) #3
rvargas (doing something else)
https://codereview.chromium.org/101203010/diff/130001/sandbox/win/src/service_resolver_64.cc File sandbox/win/src/service_resolver_64.cc (right): https://codereview.chromium.org/101203010/diff/130001/sandbox/win/src/service_resolver_64.cc#newcode183 sandbox/win/src/service_resolver_64.cc:183: bool Win8ResolverThunk::IsFunctionAService(void* local_thunk) const { We cannot do this. ...
6 years, 11 months ago (2014-01-07 23:38:34 UTC) #4
csharp
https://codereview.chromium.org/101203010/diff/130001/sandbox/win/src/service_resolver_64.cc File sandbox/win/src/service_resolver_64.cc (right): https://codereview.chromium.org/101203010/diff/130001/sandbox/win/src/service_resolver_64.cc#newcode183 sandbox/win/src/service_resolver_64.cc:183: bool Win8ResolverThunk::IsFunctionAService(void* local_thunk) const { On 2014/01/07 23:38:34, rvargas ...
6 years, 11 months ago (2014-01-08 14:48:19 UTC) #5
rvargas (doing something else)
Sorry for the delay. https://codereview.chromium.org/101203010/diff/130001/sandbox/win/src/service_resolver_64.cc File sandbox/win/src/service_resolver_64.cc (right): https://codereview.chromium.org/101203010/diff/130001/sandbox/win/src/service_resolver_64.cc#newcode183 sandbox/win/src/service_resolver_64.cc:183: bool Win8ResolverThunk::IsFunctionAService(void* local_thunk) const { ...
6 years, 11 months ago (2014-01-09 01:12:00 UTC) #6
csharp
On 2014/01/09 01:12:00, rvargas wrote: > Sorry for the delay. Sorry for the longer delay ...
6 years, 11 months ago (2014-01-24 19:12:24 UTC) #7
rvargas (doing something else)
lgtm https://codereview.chromium.org/101203010/diff/260001/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/101203010/diff/260001/chrome_elf/blacklist/blacklist.cc#newcode296 chrome_elf/blacklist/blacklist.cc:296: // ServiceResolverThunk can handle all the formata in ...
6 years, 11 months ago (2014-01-27 19:15:32 UTC) #8
csharp
Robert, can you take another look at the blacklist files? https://codereview.chromium.org/101203010/diff/260001/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/101203010/diff/260001/chrome_elf/blacklist/blacklist.cc#newcode296 ...
6 years, 10 months ago (2014-02-03 16:23:08 UTC) #9
robertshield
https://codereview.chromium.org/101203010/diff/320001/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/101203010/diff/320001/chrome_elf/blacklist/blacklist.cc#newcode337 chrome_elf/blacklist/blacklist.cc:337: BOOL page_executable; initialize to FALSE. https://codereview.chromium.org/101203010/diff/320001/chrome_elf/blacklist/blacklist.cc#newcode373 chrome_elf/blacklist/blacklist.cc:373: page_executable &= ...
6 years, 10 months ago (2014-02-06 20:04:33 UTC) #10
csharp
https://codereview.chromium.org/101203010/diff/320001/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/101203010/diff/320001/chrome_elf/blacklist/blacklist.cc#newcode337 chrome_elf/blacklist/blacklist.cc:337: BOOL page_executable; On 2014/02/06 20:04:33, robertshield wrote: > initialize ...
6 years, 10 months ago (2014-02-06 22:29:24 UTC) #11
robertshield
lgtm
6 years, 10 months ago (2014-02-07 04:44:54 UTC) #12
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 10 months ago (2014-02-07 15:19:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/101203010/400001
6 years, 10 months ago (2014-02-07 15:19:57 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 20:23:36 UTC) #15
Message was sent while issue was closed.
Change committed as 249755

Powered by Google App Engine
This is Rietveld 408576698