chrome_elf/blacklist/test/blacklist_test.cc - Issue 101203010: Add 64-bit support to browser blacklisting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/blacklist/test/blacklist_test.cc

Issue 101203010: Add 64-bit support to browser blacklisting (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: responding to comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_elf/blacklist/test/blacklist_test.cc

diff --git a/chrome_elf/blacklist/test/blacklist_test.cc b/chrome_elf/blacklist/test/blacklist_test.cc

index 07623cdfd05feada0d46b879175b6e55cfe65ff0..3a881ad1cfa2c3ba23fbd885c7d929ddc0b2dd8e 100644

--- a/chrome_elf/blacklist/test/blacklist_test.cc

+++ b/chrome_elf/blacklist/test/blacklist_test.cc

@@ -117,8 +117,6 @@ TEST_F(BlacklistTest, AddAndRemoveModules) {

}

TEST_F(BlacklistTest, LoadBlacklistedLibrary) {

-// TODO(robertshield): Add 64-bit support.

-#if !defined(_WIN64)

base::FilePath current_dir;

ASSERT_TRUE(PathService::Get(base::DIR_EXE, &current_dir));

@@ -167,5 +165,4 @@ TEST_F(BlacklistTest, LoadBlacklistedLibrary) {

EXPECT_TRUE(TestDll_RemoveDllFromBlacklist(uppercase_name.c_str()));

}

-#endif

}