Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 101203008: Allow app_shell to run past extension manifest parsing (Closed)

Created:
6 years, 11 months ago by James Cook
Modified:
6 years, 11 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Allow app_shell to run past extension manifest parsing * Extracted non-Chrome-specific manifest handler registration into src/extensions/common/common_manfiest_handlers.cc * Moved app_shell app load/launch code into ShellExtensionSystem so it can signal that the system is ready * Refactored more of runtime API to use browser context instead of Profile * Cleaned up or removed some uses of ExtensionService This allows app_shell to get into the background page loading code before it crashes. BUG=162530, 288226, 309909 TEST=existing browser_tests of extension system Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243343

Patch Set 1 #

Patch Set 2 : cleanup register_manifest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -78 lines) Patch
M apps/shell/shell_browser_main_parts.h View 2 chunks +0 lines, -8 lines 0 comments Download
M apps/shell/shell_browser_main_parts.cc View 3 chunks +1 line, -22 lines 0 comments Download
M apps/shell/shell_extension_system.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M apps/shell/shell_extension_system.cc View 3 chunks +46 lines, -1 line 0 comments Download
M apps/shell/shell_extensions_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_web_contents_observer.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 3 chunks +2 lines, -20 lines 0 comments Download
M extensions/browser/process_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A extensions/common/common_manifest_handlers.h View 1 chunk +17 lines, -0 lines 0 comments Download
A extensions/common/common_manifest_handlers.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M extensions/common/extensions_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/manifest_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
yoz, PTAL
6 years, 11 months ago (2014-01-06 22:13:30 UTC) #1
Yoyo Zhou
LGTM, nice!
6 years, 11 months ago (2014-01-07 03:43:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/101203008/30001
6 years, 11 months ago (2014-01-07 16:08:23 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 18:52:12 UTC) #4
Message was sent while issue was closed.
Change committed as 243343

Powered by Google App Engine
This is Rietveld 408576698