Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: apps/shell/shell_extensions_client.cc

Issue 101203008: Allow app_shell to run past extension manifest parsing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup register_manifest Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/shell/shell_extensions_client.h" 5 #include "apps/shell/shell_extensions_client.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/common/extensions/features/base_feature_provider.h" 8 #include "chrome/common/extensions/features/base_feature_provider.h"
9 #include "extensions/common/common_manifest_handlers.h"
10 #include "extensions/common/manifest_handler.h"
9 #include "extensions/common/permissions/permission_message_provider.h" 11 #include "extensions/common/permissions/permission_message_provider.h"
10 #include "extensions/common/permissions/permissions_provider.h" 12 #include "extensions/common/permissions/permissions_provider.h"
11 #include "extensions/common/url_pattern_set.h" 13 #include "extensions/common/url_pattern_set.h"
12 14
13 using extensions::APIPermissionInfo; 15 using extensions::APIPermissionInfo;
14 using extensions::APIPermissionSet; 16 using extensions::APIPermissionSet;
15 using extensions::Extension; 17 using extensions::Extension;
16 using extensions::Manifest; 18 using extensions::Manifest;
17 using extensions::PermissionMessage; 19 using extensions::PermissionMessage;
18 using extensions::PermissionMessages; 20 using extensions::PermissionMessages;
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 86
85 } // namespace 87 } // namespace
86 88
87 ShellExtensionsClient::ShellExtensionsClient() { 89 ShellExtensionsClient::ShellExtensionsClient() {
88 } 90 }
89 91
90 ShellExtensionsClient::~ShellExtensionsClient() { 92 ShellExtensionsClient::~ShellExtensionsClient() {
91 } 93 }
92 94
93 void ShellExtensionsClient::Initialize() { 95 void ShellExtensionsClient::Initialize() {
96 extensions::RegisterCommonManifestHandlers();
97 extensions::ManifestHandler::FinalizeRegistration();
98
94 // TODO(jamescook): Do we need to whitelist any extensions? 99 // TODO(jamescook): Do we need to whitelist any extensions?
95 } 100 }
96 101
97 const extensions::PermissionsProvider& 102 const extensions::PermissionsProvider&
98 ShellExtensionsClient::GetPermissionsProvider() const { 103 ShellExtensionsClient::GetPermissionsProvider() const {
99 NOTIMPLEMENTED(); 104 NOTIMPLEMENTED();
100 static ShellPermissionsProvider provider; 105 static ShellPermissionsProvider provider;
101 return provider; 106 return provider;
102 } 107 }
103 108
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 return URLPatternSet(); 144 return URLPatternSet();
140 } 145 }
141 146
142 bool ShellExtensionsClient::IsScriptableURL(const GURL& url, 147 bool ShellExtensionsClient::IsScriptableURL(const GURL& url,
143 std::string* error) const { 148 std::string* error) const {
144 NOTIMPLEMENTED(); 149 NOTIMPLEMENTED();
145 return true; 150 return true;
146 } 151 }
147 152
148 } // namespace apps 153 } // namespace apps
OLDNEW
« no previous file with comments | « apps/shell/shell_extension_system.cc ('k') | chrome/browser/extensions/api/runtime/runtime_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698