Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1012023002: Merge old data and pointer space. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Merge old data and pointer space. BUG= Committed: https://crrev.com/257ff4893114854519530957c2eeb97c15cd359f Cr-Commit-Position: refs/heads/master@{#27259}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+626 lines, -1125 lines) Patch
M include/v8.h View 1 2 3 1 chunk +9 lines, -10 lines 0 comments Download
M src/api.cc View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
M src/assembler.cc View 1 2 1 chunk +4 lines, -20 lines 0 comments Download
M src/counters.h View 1 2 2 chunks +26 lines, -46 lines 0 comments Download
M src/extensions/statistics-extension.cc View 1 2 1 chunk +3 lines, -9 lines 0 comments Download
M src/factory.cc View 1 2 5 chunks +5 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/globals.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 10 chunks +40 lines, -65 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 45 chunks +85 lines, -158 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 3 4 5 6 chunks +15 lines, -68 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 4 chunks +3 lines, -17 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 6 7 8 24 chunks +38 lines, -80 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/spaces.h View 1 2 9 chunks +11 lines, -21 lines 0 comments Download
M src/heap/spaces.cc View 1 2 4 chunks +4 lines, -16 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/store-buffer.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/heap/store-buffer-inl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 4 chunks +6 lines, -15 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 4 chunks +10 lines, -74 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M src/macro-assembler.h View 1 2 3 chunks +6 lines, -15 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/serialize.cc View 1 2 4 chunks +10 lines, -21 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 5 chunks +7 lines, -11 lines 0 comments Download
M test/cctest/test-constantpool.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-dictionary.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 25 chunks +59 lines, -61 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 2 8 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-weaksets.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/grokdump.py View 1 2 3 4 5 6 7 9 chunks +14 lines, -35 lines 0 comments Download
M tools/oom_dump/oom_dump.cc View 1 2 3 4 5 6 7 2 chunks +19 lines, -23 lines 0 comments Download
M tools/v8heapconst.py View 1 2 3 4 5 6 1 chunk +152 lines, -151 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Hannes Payer (out of office)
PTAL
5 years, 9 months ago (2015-03-17 15:46:52 UTC) #2
Hannes Payer (out of office)
try jobs are in patch set 4
5 years, 9 months ago (2015-03-17 15:47:07 UTC) #3
Jakob Kummerow
DBC: Please run "make grokdump" to update tools/v8heapconst.py. Does grokdump itself need to be taught ...
5 years, 9 months ago (2015-03-17 22:10:29 UTC) #4
ulan
LGTM https://codereview.chromium.org/1012023002/diff/80001/src/counters.h File src/counters.h (right): https://codereview.chromium.org/1012023002/diff/80001/src/counters.h#newcode401 src/counters.h:401: HP(external_fragmentation_total, V8.MemoryExternalFragmentationTotal) \ This will require change in ...
5 years, 9 months ago (2015-03-18 07:27:27 UTC) #5
Hannes Payer (out of office)
https://codereview.chromium.org/1012023002/diff/100001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1012023002/diff/100001/src/heap/heap.h#newcode1762 src/heap/heap.h:1762: static AllocationSpace SelectSpace(int object_size, I think we can get ...
5 years, 9 months ago (2015-03-18 07:33:49 UTC) #6
Hannes Payer (out of office)
Thanks Jakob. I updated grokdump.
5 years, 9 months ago (2015-03-18 08:43:47 UTC) #7
Jakob Kummerow
Changes in tools/ LGTM. (I didn't look too closely; we'll find out soon enough whether ...
5 years, 9 months ago (2015-03-18 09:11:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012023002/160001
5 years, 9 months ago (2015-03-18 09:36:54 UTC) #12
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 9 months ago (2015-03-18 09:38:54 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 09:39:11 UTC) #14
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/257ff4893114854519530957c2eeb97c15cd359f
Cr-Commit-Position: refs/heads/master@{#27259}

Powered by Google App Engine
This is Rietveld 408576698