Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: test/cctest/test-weakmaps.cc

Issue 1012023002: Merge old data and pointer space. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-unboxed-doubles.cc ('k') | test/cctest/test-weaksets.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 Isolate* isolate = GetIsolateFrom(&context); 176 Isolate* isolate = GetIsolateFrom(&context);
177 Factory* factory = isolate->factory(); 177 Factory* factory = isolate->factory();
178 Heap* heap = isolate->heap(); 178 Heap* heap = isolate->heap();
179 HandleScope scope(isolate); 179 HandleScope scope(isolate);
180 Handle<JSFunction> function = factory->NewFunction( 180 Handle<JSFunction> function = factory->NewFunction(
181 factory->function_string()); 181 factory->function_string());
182 Handle<JSObject> key = factory->NewJSObject(function); 182 Handle<JSObject> key = factory->NewJSObject(function);
183 Handle<JSWeakMap> weakmap = AllocateJSWeakMap(isolate); 183 Handle<JSWeakMap> weakmap = AllocateJSWeakMap(isolate);
184 184
185 // Start second old-space page so that values land on evacuation candidate. 185 // Start second old-space page so that values land on evacuation candidate.
186 Page* first_page = heap->old_pointer_space()->anchor()->next_page(); 186 Page* first_page = heap->old_space()->anchor()->next_page();
187 int dummy_array_size = Page::kMaxRegularHeapObjectSize - 92 * KB; 187 int dummy_array_size = Page::kMaxRegularHeapObjectSize - 92 * KB;
188 factory->NewFixedArray(dummy_array_size / kPointerSize, TENURED); 188 factory->NewFixedArray(dummy_array_size / kPointerSize, TENURED);
189 189
190 // Fill up weak map with values on an evacuation candidate. 190 // Fill up weak map with values on an evacuation candidate.
191 { 191 {
192 HandleScope scope(isolate); 192 HandleScope scope(isolate);
193 for (int i = 0; i < 32; i++) { 193 for (int i = 0; i < 32; i++) {
194 Handle<JSObject> object = factory->NewJSObject(function, TENURED); 194 Handle<JSObject> object = factory->NewJSObject(function, TENURED);
195 CHECK(!heap->InNewSpace(object->address())); 195 CHECK(!heap->InNewSpace(object->address()));
196 CHECK(!first_page->Contains(object->address())); 196 CHECK(!first_page->Contains(object->address()));
(...skipping 18 matching lines...) Expand all
215 215
216 LocalContext context; 216 LocalContext context;
217 Isolate* isolate = GetIsolateFrom(&context); 217 Isolate* isolate = GetIsolateFrom(&context);
218 Factory* factory = isolate->factory(); 218 Factory* factory = isolate->factory();
219 Heap* heap = isolate->heap(); 219 Heap* heap = isolate->heap();
220 HandleScope scope(isolate); 220 HandleScope scope(isolate);
221 Handle<JSFunction> function = factory->NewFunction( 221 Handle<JSFunction> function = factory->NewFunction(
222 factory->function_string()); 222 factory->function_string());
223 223
224 // Start second old-space page so that keys land on evacuation candidate. 224 // Start second old-space page so that keys land on evacuation candidate.
225 Page* first_page = heap->old_pointer_space()->anchor()->next_page(); 225 Page* first_page = heap->old_space()->anchor()->next_page();
226 int dummy_array_size = Page::kMaxRegularHeapObjectSize - 92 * KB; 226 int dummy_array_size = Page::kMaxRegularHeapObjectSize - 92 * KB;
227 factory->NewFixedArray(dummy_array_size / kPointerSize, TENURED); 227 factory->NewFixedArray(dummy_array_size / kPointerSize, TENURED);
228 228
229 // Fill up weak map with keys on an evacuation candidate. 229 // Fill up weak map with keys on an evacuation candidate.
230 Handle<JSObject> keys[32]; 230 Handle<JSObject> keys[32];
231 for (int i = 0; i < 32; i++) { 231 for (int i = 0; i < 32; i++) {
232 keys[i] = factory->NewJSObject(function, TENURED); 232 keys[i] = factory->NewJSObject(function, TENURED);
233 CHECK(!heap->InNewSpace(keys[i]->address())); 233 CHECK(!heap->InNewSpace(keys[i]->address()));
234 CHECK(!first_page->Contains(keys[i]->address())); 234 CHECK(!first_page->Contains(keys[i]->address()));
235 } 235 }
(...skipping 20 matching lines...) Expand all
256 { 256 {
257 HandleScope scope(isolate); 257 HandleScope scope(isolate);
258 AllocateJSWeakMap(isolate); 258 AllocateJSWeakMap(isolate);
259 SimulateIncrementalMarking(heap); 259 SimulateIncrementalMarking(heap);
260 } 260 }
261 // The weak map is marked black here but leaving the handle scope will make 261 // The weak map is marked black here but leaving the handle scope will make
262 // the object unreachable. Aborting incremental marking will clear all the 262 // the object unreachable. Aborting incremental marking will clear all the
263 // marking bits which makes the weak map garbage. 263 // marking bits which makes the weak map garbage.
264 heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask); 264 heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
265 } 265 }
OLDNEW
« no previous file with comments | « test/cctest/test-unboxed-doubles.cc ('k') | test/cctest/test-weaksets.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698