content/shell/browser/layout_test/layout_test_content_browser_client.h - Issue 1011953003: Refactor Permissions related method out of ContentBrowserClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_content_browser_client.h

Issue 1011953003: Refactor Permissions related method out of ContentBrowserClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_type_enum_class

Patch Set: fix cros Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_browser_context.cc ('k') | content/shell/browser/layout_test/layout_test_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_content_browser_client.h

diff --git a/content/shell/browser/layout_test/layout_test_content_browser_client.h b/content/shell/browser/layout_test/layout_test_content_browser_client.h

index 328ce611e50e609ab83a2b702e88e114bd6bf4a7..f41794dad6719b854a24635982391bc6e3f3d08b 100644

--- a/content/shell/browser/layout_test/layout_test_content_browser_client.h

+++ b/content/shell/browser/layout_test/layout_test_content_browser_client.h

@@ -9,7 +9,6 @@

namespace content {

-enum class PermissionType;

class LayoutTestBrowserContext;

class LayoutTestNotificationManager;

@@ -28,13 +27,6 @@ class LayoutTestContentBrowserClient : public ShellContentBrowserClient {

// ContentBrowserClient overrides.

void RenderProcessWillLaunch(RenderProcessHost* host) override;

- void RequestPermission(

- PermissionType permission,

- WebContents* web_contents,

- int bridge_id,

- const GURL& requesting_frame,

- bool user_gesture,

- const base::Callback<void(PermissionStatus)>& callback) override;

PlatformNotificationService* GetPlatformNotificationService() override;

void GetAdditionalNavigatorConnectServices(