Hotword: Adds a field for always_on_available to the API StatusDetails

Hotword: Adds a field for always_on_available to the API StatusDetails

This field is used when deciding whether to show the NTP promo.

BUG=436681
Committed: https://crrev.com/b175252785cd48a5e561781eb7685484bb897453
Cr-Commit-Position: refs/heads/master@{#320874}

[kcarattini, 2015-03-17 01:46:11]

kcarattini@chromium.org changed reviewers:
+ amistry@chromium.org, benwells@chromium.org

[benwells, 2015-03-17 03:02:55]

https://codereview.chromium.org/1011913005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/hotword/page_audio_manager.js (right):

https://codereview.chromium.org/1011913005/diff/40001/chrome/browser/resource...
chrome/browser/resources/hotword/page_audio_manager.js:458:
!hotwordStatus.enabledSet && !hotwordStatus.alwaysOnAvailable) {
Why is this !available? My reading of this is that the promo will only be shown
if always on is not available, is that right?

https://codereview.chromium.org/1011913005/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/hotword_private.idl (right):

https://codereview.chromium.org/1011913005/diff/40001/chrome/common/extension...
chrome/common/extensions/api/hotword_private.idl:26: // Whether always-on is
avaialable to be enabled
Nit: available spelling

[kcarattini, 2015-03-17 04:22:17]

https://codereview.chromium.org/1011913005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/hotword/page_audio_manager.js (right):

https://codereview.chromium.org/1011913005/diff/40001/chrome/browser/resource...
chrome/browser/resources/hotword/page_audio_manager.js:458:
!hotwordStatus.enabledSet && !hotwordStatus.alwaysOnAvailable) {
On 2015/03/17 03:02:55, benwells wrote:
> Why is this !available? My reading of this is that the promo will only be
shown
> if always on is not available, is that right?

That's correct. This promo is for the 'sometimes-on' case. The always-on people
get the ChromeOS notification instead. With always-on, we always open the
launcher and do not interact with the GWS pages for hotwording. Added a comment.

https://codereview.chromium.org/1011913005/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/hotword_private.idl (right):

https://codereview.chromium.org/1011913005/diff/40001/chrome/common/extension...
chrome/common/extensions/api/hotword_private.idl:26: // Whether always-on is
avaialable to be enabled
On 2015/03/17 03:02:55, benwells wrote:
> Nit: available spelling

Done.

[benwells, 2015-03-17 04:34:39]

lgtm. thanks for adding the explanatory comment!

[Anand Mistry (off Chromium), 2015-03-17 04:57:30]

lgtm

[kcarattini, 2015-03-17 05:09:04]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2015-03-17 05:09:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1011913005/80001

[commit-bot: I haz the power, 2015-03-17 06:11:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-17 06:12:23]

Patchset 5 (id:??) landed as
https://crrev.com/b175252785cd48a5e561781eb7685484bb897453
Cr-Commit-Position: refs/heads/master@{#320874}