chrome/browser/resources/hotword/page_audio_manager.js - Issue 1011913005: Hotword: Adds a field for always_on_available to the API StatusDetails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/hotword/page_audio_manager.js

Issue 1011913005: Hotword: Adds a field for always_on_available to the API StatusDetails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Typo Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/hotword_private/hotword_private_api.cc ('k') | chrome/common/extensions/api/hotword_private.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/hotword/page_audio_manager.js

diff --git a/chrome/browser/resources/hotword/page_audio_manager.js b/chrome/browser/resources/hotword/page_audio_manager.js

index 8a67cdaba7be6ed7213ac94c6f9daf7cb670b769..8e9891fdddce360d3e3ffce77542a331b04f0caa 100644

--- a/chrome/browser/resources/hotword/page_audio_manager.js

+++ b/chrome/browser/resources/hotword/page_audio_manager.js

@@ -454,8 +454,10 @@ cr.define('hotword', function() {

statusDone_: function(tab, sendResponse, hotwordStatus) {

var response = {'doNotShowOptinMessage': true};

+ // If always-on is available, then we do not show the promo, as the promo

+ // only works with the sometimes-on pref.

if (!tab.incognito && hotwordStatus.available &&

- !hotwordStatus.enabledSet) {

+ !hotwordStatus.enabledSet && !hotwordStatus.alwaysOnAvailable) {

response = hotwordStatus;

}