Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1011733005: CpuProfiler: extract DeoptInfo fill in code into a static function. (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
alph, Sven Panne, Jarin, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: extract DeoptInfo fill in code into a static function. the third part of the patch https://codereview.chromium.org/1012633002 this patch 1) moves DeoptInfo builder code to platform independent file lithium-codegen.cc 2) adds inlining_id property to HEnterInlined so we can use it on lithium level. BUG=chromium:452067 LOG=n Committed: https://crrev.com/55d05404b74ba4545686f38a54c0fe999c7174e7 Cr-Commit-Position: refs/heads/master@{#27231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lithium-codegen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/lithium-codegen.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-16 15:52:43 UTC) #2
yurys
lgtm
5 years, 9 months ago (2015-03-16 16:36:22 UTC) #3
loislo
+jarin@
5 years, 9 months ago (2015-03-17 07:08:11 UTC) #5
Sven Panne
lgtm
5 years, 9 months ago (2015-03-17 09:32:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011733005/1
5 years, 9 months ago (2015-03-17 09:33:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 09:37:33 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 09:37:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55d05404b74ba4545686f38a54c0fe999c7174e7
Cr-Commit-Position: refs/heads/master@{#27231}

Powered by Google App Engine
This is Rietveld 408576698