Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 1011733002: CpuProfiler: convert List<InlinedFunctionInfo> into std::vector<InlinedFunctionInfo> (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: convert List<InlinedFunctionInfo> into std::vector<InlinedFunctionInfo> this is the first part of https://codereview.chromium.org/1012633002. mechanical change. The motivation: the original patch needs to use List of List but list is not copiable. BUG=chromium:452067 LOG=n Committed: https://crrev.com/3e29f36ba43cf9700f191bd1ec454cdcc800339b Cr-Commit-Position: refs/heads/master@{#27221}

Patch Set 1 #

Patch Set 2 : win64 fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/compiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
loislo
this is a part of https://codereview.chromium.org/1012633002 PTAL
5 years, 9 months ago (2015-03-16 12:29:19 UTC) #2
yurys
lgtm
5 years, 9 months ago (2015-03-16 12:32:07 UTC) #3
Sven Panne
lgtm
5 years, 9 months ago (2015-03-16 13:13:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011733002/20001
5 years, 9 months ago (2015-03-16 13:13:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 13:41:54 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 13:42:03 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e29f36ba43cf9700f191bd1ec454cdcc800339b
Cr-Commit-Position: refs/heads/master@{#27221}

Powered by Google App Engine
This is Rietveld 408576698