[Slimming Paint] Allow 3D transforms of different types.

[Slimming Paint] Allow 3D transforms of different types.

3D transforms can occur for multiple reasons, and so we need multiple types
per client. For instance, an element may have a transform, and also apply
a perspective transform to some of its children.

BUG=460986
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192040

[jbroman, 2015-03-17 03:33:41]

jbroman@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org, schenney@chromium.org

[chrishtr, 2015-03-17 19:59:14]

Why is there no other type of transform present yet then? Are we missing it?

https://codereview.chromium.org/1011703005/diff/40001/Source/core/paint/Layer...
File Source/core/paint/LayerPainter.cpp (right):

https://codereview.chromium.org/1011703005/diff/40001/Source/core/paint/Layer...
Source/core/paint/LayerPainter.cpp:589: Transform3DRecorder
transform3DRecorder(*context, m_renderLayer.layoutObject()->displayItemClient(),
DisplayItem::Transform3DElementTransform, transform);
Is this the same type as the other call site?

[jbroman, 2015-03-17 20:16:56]

On 2015/03/17 19:59:14, chrishtr wrote:
> Why is there no other type of transform present yet then? Are we missing it?

I anticipate that the perspective transform, which is not currently included in
the display item list, will need to be represented.

An element's transform is multiplied by the perspective transform of its
containing block.

In the current world, we generate a separate GraphicsLayer to represent this. In
a compositor layerization world, 

This change is intended to have zero functionality change. I anticipate that
including perspective in the display item list will occur in a subsequent CL.

https://codereview.chromium.org/1011703005/diff/40001/Source/core/paint/Layer...
File Source/core/paint/LayerPainter.cpp (right):

https://codereview.chromium.org/1011703005/diff/40001/Source/core/paint/Layer...
Source/core/paint/LayerPainter.cpp:589: Transform3DRecorder
transform3DRecorder(*context, m_renderLayer.layoutObject()->displayItemClient(),
DisplayItem::Transform3DElementTransform, transform);
On 2015/03/17 19:59:14, chrishtr wrote:
> Is this the same type as the other call site?

Yes, it is.

[chrishtr, 2015-03-17 20:20:50]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-03-17 20:20:51]

lgtm

[commit-bot: I haz the power, 2015-03-17 20:21:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1011703005/40001

[commit-bot: I haz the power, 2015-03-17 20:24:30]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192040