Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1011383007: clang/win: Don't disable warnings-as-errors for 3rd-party libs. (Closed)

Created:
5 years, 9 months ago by Nico
Modified:
5 years, 9 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Don't disable warnings-as-errors for 3rd-party libs. Not needed: On 32-bit builds, warnings-as-errors are disabled globally. On 64-bit builds, nothing warns, including 3rd-party code. BUG=82385 Committed: https://crrev.com/920d194ed55addc327674dad9b415c90fb38b73b Cr-Commit-Position: refs/heads/master@{#321433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 9 months ago (2015-03-19 19:36:05 UTC) #2
hans
On 2015/03/19 19:36:05, Nico (traveling) wrote: lgtm
5 years, 9 months ago (2015-03-19 20:25:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011383007/1
5 years, 9 months ago (2015-03-19 20:28:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 21:22:48 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 21:23:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/920d194ed55addc327674dad9b415c90fb38b73b
Cr-Commit-Position: refs/heads/master@{#321433}

Powered by Google App Engine
This is Rietveld 408576698