build/common.gypi - Issue 1011383007: clang/win: Don't disable warnings-as-errors for 3rd-party libs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1011383007: clang/win: Don't disable warnings-as-errors for 3rd-party libs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 6a40e0d13588f9b717d51c6c014d736586787582..fcfd9d34c8b0e1bce6a1f5b00e1713650540e6c5 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3101,11 +3101,6 @@

'VCCLCompilerTool': { 'WarnAsError': 'false' },

}

}],

- ['clang==1', {

- 'msvs_settings': {

- 'VCCLCompilerTool': { 'WarnAsError': 'false' },

- }

- }],

[ 'component=="shared_library"', {

# TODO(darin): Unfortunately, some third_party code depends on base.

'msvs_disabled_warnings': [

« no previous file with comments | « no previous file | no next file » | no next file with comments »