pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart - Issue 1011383003: Use an explicit 'this' parameter instead of 'This' nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

Issue 1011383003: Use an explicit 'this' parameter instead of 'This' nodes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix parent pointers on thisParameter; fix constant propagation on thisParameter Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('K') | « pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart ('k') | pkg/compiler/lib/src/cps_ir/type_propagation.dart » ('j') | pkg/compiler/lib/src/dart_backend/backend.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

diff --git a/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart b/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

index e91d58e64a5fde9fe1caa1a52b58b4e7000ae546..c3823ece560f55358510d2e298239fc3fc9ffc72 100644

--- a/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

+++ b/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

@@ -486,6 +486,7 @@ class _RemovalVisitor extends RecursiveVisitor {

class ParentVisitor extends RecursiveVisitor {

processFunctionDefinition(FunctionDefinition node) {

node.body.parent = node;

+ if (node.thisParameter != null) node.thisParameter.parent = node;

int index = 0;

node.parameters.forEach((Definition parameter) {

parameter.parent = node;