pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart - Issue 1011383003: Use an explicit 'this' parameter instead of 'This' nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1011383003: Use an explicit 'this' parameter instead of 'This' nodes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix parent pointers on thisParameter; fix constant propagation on thisParameter Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart » ('j') | pkg/compiler/lib/src/dart_backend/backend.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

index ef33a135f4deaf41d3d735f9f4bd12fb948c0ff8..67c972511c075ccc5750199fec26c6904501ea0a 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

@@ -1276,7 +1276,8 @@ class DartIrBuilderVisitor extends IrBuilderVisitor {

@override

ir.Primitive buildReifyTypeVariable(ir.Primitive target,

TypeVariableType variable) {

- assert(target is ir.This);

+ //assert(target == irBuilder.state.thisParameter);

karlklose 2015/03/20 09:43:07 Remove commented out code.

sra1 2015/03/20 10:01:42 Done.

+ assert(target == irBuilder.state.enclosingMethodThisParameter);

ir.Primitive prim = new ir.ReifyTypeVar(variable.element);

irBuilder.add(new ir.LetPrim(prim));

return prim;