Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: lib/devc.dart

Issue 1011153002: js: fix core.Object, output order, static const fields (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/runtime/dart_runtime.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/devc.dart
diff --git a/lib/devc.dart b/lib/devc.dart
index 980e2db1393619b81606b616217139632f34e3b9..27669a9f8f43dceecc64adc64651254d73ad6998 100644
--- a/lib/devc.dart
+++ b/lib/devc.dart
@@ -25,7 +25,7 @@ import 'src/codegen/dart_codegen.dart';
import 'src/codegen/html_codegen.dart';
import 'src/codegen/js_codegen.dart';
import 'src/dependency_graph.dart';
-import 'src/info.dart' show LibraryInfo, CheckerResults;
+import 'src/info.dart' show LibraryInfo, CheckerResults, LibraryUnit;
import 'src/options.dart';
import 'src/report.dart';
import 'src/utils.dart';
@@ -167,11 +167,12 @@ class Compiler {
_libraries.add(current);
_rules.currentLibraryInfo = current;
- var units = [entryUnit]
- ..addAll(node.parts.map(
- (p) => _resolver.context.resolveCompilationUnit2(p.source, source)));
+ var resolvedParts = node.parts
+ .map((p) => _resolver.context.resolveCompilationUnit2(p.source, source))
+ .toList(growable: false);
+ var libraryUnit = new LibraryUnit(entryUnit, resolvedParts);
bool failureInLib = false;
- for (var unit in units) {
+ for (var unit in libraryUnit.libraryThenParts) {
var unitSource = unit.element.source;
_reporter.enterSource(unitSource);
// TODO(sigmund): integrate analyzer errors with static-info (issue #6).
@@ -186,7 +187,7 @@ class Compiler {
}
for (var cg in _generators) {
- var hash = cg.generateLibrary(units, current, _reporter);
+ var hash = cg.generateLibrary(libraryUnit, current, _reporter);
if (_hashing) node.cachingHash = hash;
}
_reporter.leaveLibrary();
« no previous file with comments | « no previous file | lib/runtime/dart_runtime.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698