js: fix core.Object, output order, static const fields

lib/devc.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Command line tool to run the checker on a Dart program.
 library dev_compiler.devc;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:analyzer/src/generated/engine.dart' show ChangeSet;
 import 'package:logging/logging.dart' show Level, Logger, LogRecord;
 import 'package:path/path.dart' as path;
 import 'package:shelf/shelf.dart' as shelf;
 import 'package:shelf/shelf_io.dart' as shelf;
 import 'package:shelf_static/shelf_static.dart' as shelf_static;
 
 import 'src/checker/checker.dart';
 import 'src/checker/dart_sdk.dart' show mockSdkSources;
 import 'src/checker/resolver.dart';
 import 'src/checker/rules.dart';
 import 'src/codegen/code_generator.dart' show CodeGenerator;
 import 'src/codegen/dart_codegen.dart';
 import 'src/codegen/html_codegen.dart';
 import 'src/codegen/js_codegen.dart';
 import 'src/dependency_graph.dart';
-import 'src/info.dart' show LibraryInfo, CheckerResults;
+import 'src/info.dart' show LibraryInfo, CheckerResults, LibraryUnit;
 import 'src/options.dart';
 import 'src/report.dart';
 import 'src/utils.dart';
 
 /// Sets up the type checker logger to print a span that highlights error
 /// messages.
 StreamSubscription setupLogger(Level level, printFn) {
   Logger.root.level = level;
   return Logger.root.onRecord.listen((LogRecord rec) {
     printFn('${rec.level.name.toLowerCase()}: ${rec.message}');
@@ skipping 121 matching lines @@
     var current = node.info;
     if (current != null) {
       assert(current.library == lib);
     } else {
       node.info = current = new LibraryInfo(lib, _isEntry(node));
     }
     _reporter.enterLibrary(source.uri);
     _libraries.add(current);
     _rules.currentLibraryInfo = current;
 
-    var units = [entryUnit]
-      ..addAll(node.parts.map(
-          (p) => _resolver.context.resolveCompilationUnit2(p.source, source)));
+    var resolvedParts = node.parts
+        .map((p) => _resolver.context.resolveCompilationUnit2(p.source, source))
+        .toList(growable: false);
+    var libraryUnit = new LibraryUnit(entryUnit, resolvedParts);
     bool failureInLib = false;
-    for (var unit in units) {
+    for (var unit in libraryUnit.libraryThenParts) {
       var unitSource = unit.element.source;
       _reporter.enterSource(unitSource);
       // TODO(sigmund): integrate analyzer errors with static-info (issue #6).
       failureInLib = _resolver.logErrors(unitSource, _reporter) || failureInLib;
       unit.visitChildren(_checker);
       if (_checker.failure) failureInLib = true;
       _reporter.leaveSource();
     }
     if (failureInLib) {
       _failure = true;
       if (!_options.forceCompile) return;
     }
 
     for (var cg in _generators) {
-      var hash = cg.generateLibrary(units, current, _reporter);
+      var hash = cg.generateLibrary(libraryUnit, current, _reporter);
       if (_hashing) node.cachingHash = hash;
     }
     _reporter.leaveLibrary();
   }
 
   CheckerResults run() {
     var clock = new Stopwatch()..start();
 
     // TODO(sigmund): we are missing a couple failures here. The
     // dependendency_graph now detects broken imports or unsupported features
@@ skipping 102 matching lines @@
       // Note: the cache-control header should be enough, but this doesn't hurt
       // and can help renew the policy after it expires.
       headers['ETag'] = segments[1];
     }
     return response.change(headers: headers);
   };
 }
 
 final _log = new Logger('dev_compiler');
 final _earlyErrorResult = new CheckerResults(const [], null, true);