Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 1011143002: Remove unused parameter in RenderFrameHostDelegate::DidStopLoading. (Closed)

Created:
5 years, 9 months ago by Fabrice (no longer in Chrome)
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@unused_rvh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused parameter in RenderFrameHostDelegate::DidStopLoading. BUG=429399 Committed: https://crrev.com/c73eec2e3602ab1a9e4ec702bb7df36096253acb Cr-Commit-Position: refs/heads/master@{#321356}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/browser/frame_host/render_frame_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fabrice (no longer in Chrome)
PTAL Remove all the arguments.
5 years, 9 months ago (2015-03-19 13:58:45 UTC) #2
nasko
LGTM
5 years, 9 months ago (2015-03-19 14:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011143002/20001
5 years, 9 months ago (2015-03-19 14:06:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 14:48:18 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 14:48:39 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c73eec2e3602ab1a9e4ec702bb7df36096253acb
Cr-Commit-Position: refs/heads/master@{#321356}

Powered by Google App Engine
This is Rietveld 408576698