Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1011143002: Remove unused parameter in RenderFrameHostDelegate::DidStopLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unused_rvh
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index e4b6bafc002ae44bd2915ad20ce704707886f0da..8dd4307ff3f92548ebead500cf6c375d193c2f08 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3027,7 +3027,7 @@ void WebContentsImpl::OnDidStopLoading() {
tracked_objects::ScopedTracker tracking_profile4(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"465796 WebContentsImpl::OnDidStopLoading::WCIDidStopLoading"));
- DidStopLoading(rfh);
+ DidStopLoading();
}
// TODO(erikchen): Remove ScopedTracker below once crbug.com/465796 is
@@ -3954,7 +3954,7 @@ void WebContentsImpl::DidStartLoading(RenderFrameHost* render_frame_host,
manager->UserIsNavigatingAway();
}
-void WebContentsImpl::DidStopLoading(RenderFrameHost* render_frame_host) {
+void WebContentsImpl::DidStopLoading() {
scoped_ptr<LoadNotificationDetails> details;
// Use the last committed entry rather than the active one, in case a
@@ -4504,7 +4504,7 @@ void WebContentsImpl::OnDialogClosed(int render_process_id,
// If a beforeunload dialog is canceled, we need to stop the throbber from
// spinning, since we forced it to start spinning in Navigate.
if (rfh)
- DidStopLoading(rfh);
+ DidStopLoading();
controller_.DiscardNonCommittedEntries();
FOR_EACH_OBSERVER(WebContentsObserver, observers_,
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698