Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: gin/test/v8_test.cc

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate review comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/test/v8_test.cc
diff --git a/gin/test/v8_test.cc b/gin/test/v8_test.cc
index a02251128a2c1bd13f776e1ca7b6a6fe405749eb..b0d20362938f6c8920f6c3ec34e8d3233a5dfc72 100644
--- a/gin/test/v8_test.cc
+++ b/gin/test/v8_test.cc
@@ -6,10 +6,7 @@
#include "gin/array_buffer.h"
#include "gin/public/isolate_holder.h"
-
-#ifdef V8_USE_EXTERNAL_STARTUP_DATA
-#include "gin/public/isolate_holder.h"
-#endif
+#include "gin/v8_initializer.h"
using v8::Context;
using v8::Local;
@@ -25,10 +22,11 @@ V8Test::~V8Test() {
void V8Test::SetUp() {
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
- gin::IsolateHolder::LoadV8Snapshot();
+ gin::V8Initializer::LoadV8Snapshot();
#endif
- gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
+ gin::V8Initializer::Initialize(gin::IsolateHolder::kStrictMode,
gin::ArrayBufferAllocator::SharedInstance());
+
instance_.reset(new gin::IsolateHolder);
instance_->isolate()->Enter();
HandleScope handle_scope(instance_->isolate());

Powered by Google App Engine
This is Rietveld 408576698