Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}.

gin/test/file_runner.cc

Index: gin/test/file_runner.cc
diff --git a/gin/test/file_runner.cc b/gin/test/file_runner.cc
index b639d0640630e8821cb01ccd330b15e1eed8396f..7db20abf5832763b8614e090706310e298fc2ebc 100644
--- a/gin/test/file_runner.cc
+++ b/gin/test/file_runner.cc
@@ -17,12 +17,9 @@
 #include "gin/test/gc.h"
 #include "gin/test/gtest.h"
 #include "gin/try_catch.h"
+#include "gin/v8_initializer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-#ifdef V8_USE_EXTERNAL_STARTUP_DATA
-#include "gin/public/isolate_holder.h"
-#endif
-
 namespace gin {
 
 namespace {
@@ -63,11 +60,12 @@ void RunTestFromFile(const base::FilePath& path, FileRunnerDelegate* delegate,
   base::MessageLoop message_loop;
 
 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
-  gin::IsolateHolder::LoadV8Snapshot();
+  gin::V8Initializer::LoadV8Snapshot();
 #endif
 
-  gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
+  gin::V8Initializer::Initialize(gin::IsolateHolder::kStrictMode,

[rmcilroy, 2015/03/30 17:44:18]

I think this should still be gin::IsolateHolder::Initialize() (and similarly
throughout).

[oth, 2015/03/31 09:34:47]

Done.

                                  gin::ArrayBufferAllocator::SharedInstance());
+
   gin::IsolateHolder instance;
   gin::ShellRunner runner(delegate, instance.isolate());
   {