Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gin/test/file_runner.cc

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix DEPS for Android Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/test/file_runner.cc
diff --git a/gin/test/file_runner.cc b/gin/test/file_runner.cc
index b639d0640630e8821cb01ccd330b15e1eed8396f..e82e8a00e6c0cf503823e0fac5f39b4400c16454 100644
--- a/gin/test/file_runner.cc
+++ b/gin/test/file_runner.cc
@@ -17,12 +17,9 @@
#include "gin/test/gc.h"
#include "gin/test/gtest.h"
#include "gin/try_catch.h"
+#include "gin/v8_initializer.h"
#include "testing/gtest/include/gtest/gtest.h"
-#ifdef V8_USE_EXTERNAL_STARTUP_DATA
-#include "gin/public/isolate_holder.h"
-#endif
-
namespace gin {
namespace {
@@ -63,11 +60,12 @@ void RunTestFromFile(const base::FilePath& path, FileRunnerDelegate* delegate,
base::MessageLoop message_loop;
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
- gin::IsolateHolder::LoadV8Snapshot();
+ gin::V8Initializer::LoadV8Snapshot();
#endif
- gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
+ gin::V8Initializer::Initialize(gin::V8Initializer::kStrictMode,
gin::ArrayBufferAllocator::SharedInstance());
+
gin::IsolateHolder instance;
gin::ShellRunner runner(delegate, instance.isolate());
{

Powered by Google App Engine
This is Rietveld 408576698