Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: gin/shell_runner_unittest.cc

Issue 1011133006: Move V8 snapshot loading code from isolate_holder to gin/v8_startup_data.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix DEPS for Android Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/shell_runner_unittest.cc
diff --git a/gin/shell_runner_unittest.cc b/gin/shell_runner_unittest.cc
index 7134de16dc72ecc94fe96541b3182832904642ec..ddcf7991135087fe8ebdfbe27bc4d7727cce7776 100644
--- a/gin/shell_runner_unittest.cc
+++ b/gin/shell_runner_unittest.cc
@@ -8,6 +8,7 @@
#include "gin/array_buffer.h"
#include "gin/converter.h"
#include "gin/public/isolate_holder.h"
+#include "gin/v8_initializer.h"
#include "testing/gtest/include/gtest/gtest.h"
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
@@ -25,10 +26,10 @@ TEST(RunnerTest, Run) {
std::string source = "this.result = 'PASS';\n";
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
- gin::IsolateHolder::LoadV8Snapshot();
+ gin::V8Initializer::LoadV8Snapshot();
#endif
- gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
+ gin::V8Initializer::Initialize(gin::V8Initializer::kStrictMode,
gin::ArrayBufferAllocator::SharedInstance());
gin::IsolateHolder instance;

Powered by Google App Engine
This is Rietveld 408576698