Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/net/cert/x509_certificate.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/base/keygen_handler_win.cc ('k') | trunk/src/net/http/http_auth_gssapi_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/cert/x509_certificate.cc
===================================================================
--- trunk/src/net/cert/x509_certificate.cc (revision 239920)
+++ trunk/src/net/cert/x509_certificate.cc (working copy)
@@ -665,7 +665,8 @@
if (der_encoded.empty())
return false;
std::string b64_encoded;
- base::Base64Encode(der_encoded, &b64_encoded);
+ if (!base::Base64Encode(der_encoded, &b64_encoded) || b64_encoded.empty())
+ return false;
*pem_encoded = "-----BEGIN CERTIFICATE-----\n";
// Divide the Base-64 encoded data into 64-character chunks, as per
« no previous file with comments | « trunk/src/net/base/keygen_handler_win.cc ('k') | trunk/src/net/http/http_auth_gssapi_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698