Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: trunk/src/net/base/keygen_handler_win.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/net/base/keygen_handler_win.cc
===================================================================
--- trunk/src/net/base/keygen_handler_win.cc (revision 239920)
+++ trunk/src/net/base/keygen_handler_win.cc (working copy)
@@ -211,7 +211,10 @@
}
std::string result;
- base::Base64Encode(spkac, &result);
+ if (!base::Base64Encode(spkac, &result)) {
+ LOG(ERROR) << "Keygen failed: Couldn't convert signed key into base64";
+ return std::string();
+ }
VLOG(1) << "Keygen succeeded";
return result;

Powered by Google App Engine
This is Rietveld 408576698